Skip to content

gh-137017: Fix Thread.is_alive() to only return False after the underlying OS thread exits #137315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 15, 2025
Merged

gh-137017: Fix Thread.is_alive() to only return False after the underlying OS thread exits #137315

merged 5 commits into from
Sep 15, 2025

Conversation

Abdoulrasheed
Copy link
Contributor

@Abdoulrasheed Abdoulrasheed commented Aug 1, 2025 •
edited by bedevere-app bot
Loading

Ensure Thread.is_alive() only returns False after the underlying OS thread exits.

@bedevere-app bedevere-app bot mentioned this pull request Aug 1, 2025
Closed
@Abdoulrasheed
Copy link
Contributor Author

@colesbury, gentle reminder on this PR when you have a moment.

colesbury
colesbury reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abdoulrasheed. Looks good with a minor comment below

@colesbury colesbury enabled auto-merge (squash) September 15, 2025 10:52
@colesbury colesbury merged commit aa9ceb1 into python:main Sep 15, 2025
49 checks passed
@colesbury colesbury added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 15, 2025
@miss-islington-app
Copy link

Thanks @Abdoulrasheed for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @Abdoulrasheed for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2025
@Abdoulrasheed @miss-islington
pythongh-137017: Ensure Thread.is_alive() only returns False after …
685157f 
…the underlying OS thread exits (pythongh-137315)

(cherry picked from commit aa9ceb1)

Co-authored-by: Abdul <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2025
@Abdoulrasheed @miss-islington
pythongh-137017: Ensure Thread.is_alive() only returns False after …
aae4ad7 
…the underlying OS thread exits (pythongh-137315)

(cherry picked from commit aa9ceb1)

Co-authored-by: Abdul <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 15, 2025

GH-138916 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 15, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 15, 2025

GH-138917 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 15, 2025
colesbury added a commit that referenced this pull request Sep 15, 2025
@miss-islington @Abdoulrasheed @colesbury
[3.13] gh-137017: Ensure Thread.is_alive() only returns False after…
7160f9f 
… the underlying OS thread exits (gh-137315) (gh-138917)

(cherry picked from commit aa9ceb1)

Co-authored-by: Abdul <[email protected]>
Co-authored-by: Sam Gross <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.13 (tier-2) has failed when building commit 7160f9f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1396/builds/1595) and take a look at the build logs.
  4. Check if the failure is related to this commit (7160f9f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1396/builds/1595

Failed tests:

  • test.test_multiprocessing_spawn.test_processes

Failed subtests:

  • test_repr_rlock - test.test_multiprocessing_spawn.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1492, in test_repr_rlock
    self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>

colesbury added a commit that referenced this pull request Oct 7, 2025
@miss-islington @Abdoulrasheed @colesbury
[3.14] gh-137017: Ensure Thread.is_alive() only returns False after…
9e13cc2 
… the underlying OS thread exits (gh-137315) (gh-138916)

(cherry picked from commit aa9ceb1)

Co-authored-by: Abdul <[email protected]>
Co-authored-by: Sam Gross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Abdoulrasheed @bedevere-bot @colesbury